PGCon2011 - Add 4 Video (2015.09.18)

PGCon 2011
The PostgreSQL Conference

Stephen Frost
Day Talks - 1 - 2011-05-19
Room DMS 1140
Start time 11:30
Duration 01:00
ID 368
Event type Lecture
Track Hacking

Review of Patch Reviewing

How to Review Patches for PostgreSQL

Patch reviewing is an important part of moving PostgreSQL forward. It's critical for anyone submitting patches to PostgreSQL to also understand how to review patches, too. This talk will go through the steps of patch review, including the most important piece- code review.

PostgreSQL, more than most applications, must be stable and reliable. Crashes are just not acceptable, ever. Data loss must be prevented. Add to this the many complexities of meeting the requirements of ACID and SQL, and it's clear that the code in PostgreSQL needs to be reviewed very carefully. We depend on the committers to do final review and commit, but they are a very finite resource. The PostgreSQL community has an excellent approach to scaling up our committer resources- make sure what they're reviewing is of good quality.

We'll talk about how to become a reviewer, how to use the CommitFest application, what makes a good pre-committer review, some tricks to doing reviews, and what to look for when doing a code review.